Bug 985251 - GCC6: gstreamer-0_10-plugin-crystalhd fails to build
GCC6: gstreamer-0_10-plugin-crystalhd fails to build
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Other
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: Dominique Leuenberger
E-mail List
:
Depends on:
Blocks: 984984
  Show dependency treegraph
 
Reported: 2016-06-16 17:27 UTC by Dominique Leuenberger
Modified: 2016-07-25 08:01 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Leuenberger 2016-06-16 17:27:53 UTC
Since the update to GCC6, openSUSE:Factory/ gstreamer-0_10-plugin-crystalhd fails to build
Comment 1 Takashi Iwai 2016-06-17 10:31:32 UTC
Where can I find the build failure?  It builds fine locally.
Comment 2 Dominique Leuenberger 2016-06-17 10:36:12 UTC
(In reply to Takashi Iwai from comment #1)
> Where can I find the build failure?  It builds fine locally.

https://build.opensuse.org/package/live_build_log/openSUSE:Factory/gstreamer-0_10-plugin-crystalhd/standard/x86_64

Depending on what against you build locally (openSUSE:Factory/snapshot?) you still use gcc5...

try osc build --alternative-project openSUSE:Factory standard x86_64
Comment 3 Takashi Iwai 2016-06-17 10:41:32 UTC
Thanks, I saw snapshot instead of standard...
Comment 4 Takashi Iwai 2016-06-17 10:53:21 UTC
This looks more like a bug in gstreamer-0_10-plugins-base-devel.

[   69s] In file included from gstbcmdec.c:42:0:
[   69s] /usr/include/gstreamer-0.10/gst/video/video.h:345:7: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
[   69s]        "width = "GST_VIDEO_SIZE_RANGE" , "                  \
[   69s]        ^
[   69s] /usr/include/gstreamer-0.10/gst/video/video.h:347:7: error: invalid suffix on literal; C++11 requires a space between literal and string macro [-Werror=literal-suffix]
[   69s]        "framerate = "GST_VIDEO_FPS_RANGE
[   69s]        ^
[   70s] cc1plus: all warnings being treated as errors

You need to put a space between "width =" and GST_VIDEO_SIZE_RANGE.
Comment 5 Dominique Leuenberger 2016-06-17 10:57:41 UTC
(In reply to Takashi Iwai from comment #4)
> This looks more like a bug in gstreamer-0_10-plugins-base-devel.
> 
> [   69s] In file included from gstbcmdec.c:42:0:
> [   69s] /usr/include/gstreamer-0.10/gst/video/video.h:345:7: error: invalid
> suffix on literal; C++11 requires a space between literal and string macro
> [-Werror=literal-suffix]
> [   69s]        "width = "GST_VIDEO_SIZE_RANGE" , "                  \
> [   69s]        ^
> [   69s] /usr/include/gstreamer-0.10/gst/video/video.h:347:7: error: invalid
> suffix on literal; C++11 requires a space between literal and string macro
> [-Werror=literal-suffix]
> [   69s]        "framerate = "GST_VIDEO_FPS_RANGE
> [   69s]        ^
> [   70s] cc1plus: all warnings being treated as errors
> 
> You need to put a space between "width =" and GST_VIDEO_SIZE_RANGE.

Thanks for checking and hunting it (sorry for the mis-assignment in this case - I filed like 150 bugs - and did not read all build logs :P )

so funnily, gst itself does not use that header -r forgets to trip over it.

I'll fix gstreamer-0_10-plugins-base and test with your package
Comment 6 Dominique Leuenberger 2016-06-17 11:25:14 UTC
Request: #402917

  submit:       home:dimstar:Factory/gstreamer-0_10-plugins-base@2(cleanup) -> multimedia:libs


Message:
- Add gstreamer-0_10-plugins-base-gcc6-fixes.patch: Fix header
  files to now fail when being used with gcc 6 (boo#985251).


=>  gstreamer-0_10-plugin-crystalhd built successfully in my branch, marking fixed
Comment 7 Takashi Iwai 2016-06-17 12:23:24 UTC
(In reply to Dominique Leuenberger from comment #6)
> Request: #402917
> 
>   submit:       home:dimstar:Factory/gstreamer-0_10-plugins-base@2(cleanup)
> -> multimedia:libs
> 
> 
> Message:
> - Add gstreamer-0_10-plugins-base-gcc6-fixes.patch: Fix header
>   files to now fail when being used with gcc 6 (boo#985251).
> 
> 
> =>  gstreamer-0_10-plugin-crystalhd built successfully in my branch, marking
> fixed

Thanks!