Bug 959912 - xdg-su does not recognize LXQt session
xdg-su does not recognize LXQt session
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Distribution
Classification: openSUSE
Component: X11 Applications
Leap 42.1
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: Simon Lees
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-12-21 14:40 UTC by S. B.
Modified: 2016-11-29 17:14 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description S. B. 2015-12-21 14:40:33 UTC
Hello,

xdg-su (and the rest of the XDG utilities) do not recognize the LXQt session. Therefore, gnomesu is not used to launch programs that require root access.

Thanks.
Comment 1 Marc Schlegel 2016-07-25 11:25:41 UTC
Having the same issue. Would be great if this could be fixed with 42.2.
Comment 2 Simon Lees 2016-08-07 11:36:15 UTC
This shouldn't be too hard to fix (now that I stumbled across the bug), it probably shouldn't launch gnomesu (probably pulls in too many deps) it should probably use one of the terminal based fallbacks.
Comment 3 Simon Lees 2016-08-08 02:20:45 UTC
I've looked into this
Comment 4 Simon Lees 2016-08-08 02:35:05 UTC
(In reply to Simon Lees from comment #3)
> I've looked into this

Bugzilla is silly sometimes 

I've looked into this and currently the behavior is as expected, changing LXQt to use gnomesu will likely pull in several gtk/gnome deps that were not needed previously, similarly with the kde equivalent. I'm guessing its currently possible to run LXQt with no gnome/gtk deps and some people may want to preserve that. I've added the LXQt maintainer so he can let us know if there is extra dependencies that would be pulled in if there is or he is happy to do so it won't be too hard to make the change.

I also briefly looked at qterminal instead of xterm to see if it could look nicer for the password prompt (under enlightenment we use its terminal instead of xterm as that is the case) however, doing so here would require a command line option to qterm to set the window size and a second option to disable the menu/tabs. 

There is a further question of whether the generic implementation should first check to see if gnomesu / kde-su is available on the system and use that instead of xterm when present but I'd rather discuss that upstream and do a upstream implementation for that.
Comment 5 S. B. 2016-08-08 02:59:09 UTC
> There is a further question of whether the generic implementation should first check to see if gnomesu / kde-su is available on the system and use that instead of xterm when present

This would make the most sense in my opinion.
Comment 6 Simon Lees 2016-08-08 05:53:23 UTC
well having looked further lxqt-sudo exists and works so I think I'll update it to use that for lxqt. This will also involve adding lxqt-sudo to the pattern.
Comment 7 Michael Vetter 2016-08-08 08:40:04 UTC
Hi,
I am aware of this since several weeks and its on my To-Do list.
I wanted to do it properly and add xdg to xdg-su (and send patches upstream).

LXQt upstream has tried to get LXQt into the freedesktop stuff before but failed, I don't remember why but guess it was just getting forgotten by them or similar. Jerome Leclanche, from the LXQt team, knows more about this.

Yes there exists lxqt-sudo and my goal was to patch xdg-su so it will start it when LXQt is recognized as the running session.

The previous maintainers of LXQt on openSUSE decided to use gnomesu as an alternative since AFAIK at this time lxqt-sudo didn't exist.

Adding new functionallity to QTerminal should be trivial, the code is easily readable and the main developer of it is both a member of LXQt and also involved and using openSUSE. But let's open another bug for this where we discuss what needs to be changed etc.

I spotted a lot of things that can be improved and am working on it and hope to do it for the new relase 0.11 which was supposed to come out several weeks (months?) ago but got delayed. Which is not big a drawback since I didn't have much time during that time anyways ;-)

If anybody wants to patch xdg-su feel free to do so. Currently I am working on LXQt git builds, which then should enable us to spot mistakes early on and also be very quick when a new upstream release comes up since we will already have fitting spec files.
Comment 8 S. B. 2016-11-02 04:12:59 UTC
Hi there, lxqt-sudo is now in Tumbleweed. Would it be possible to patch xdg-su to support it? It looks like somebody tried to do that here:
https://build.opensuse.org/package/view_file/home:awissu:branches:X11:common:Factory/xdg-utils/lxqt-sudo-support.patch?expand=0

Thanks!
Comment 9 Simon Lees 2016-11-02 04:35:17 UTC
(In reply to S. B. from comment #8)
> Hi there, lxqt-sudo is now in Tumbleweed. Would it be possible to patch
> xdg-su to support it? It looks like somebody tried to do that here:
> https://build.opensuse.org/package/view_file/home:awissu:branches:X11:common:
> Factory/xdg-utils/lxqt-sudo-support.patch?expand=0
> 
> Thanks!

A patch also exists in my home project home:simotek:base which covers everything possible with lxqt I'm about to try and get it included upstream, after that or if that takes too long it will hit tumbleweed (I was even looking at this today)

https://build.opensuse.org/package/show/home:simotek:base/xdg-utils
Comment 10 S. B. 2016-11-02 04:39:20 UTC
Excellent, thanks very much Simon!
Comment 11 Simon Lees 2016-11-15 00:32:13 UTC
This one was resolved a while back
Comment 12 Bernhard Wiedemann 2016-11-18 01:00:30 UTC
This is an autogenerated message for OBS integration:
This bug (959912) was mentioned in
https://build.opensuse.org/request/show/440780 13.2+42.1+42.2 / xdg-utils
Comment 13 Swamp Workflow Management 2016-11-29 16:07:46 UTC
openSUSE-RU-2016:2939-1: An update that has one recommended fix can now be installed.

Category: recommended (moderate)
Bug References: 959912
CVE References: 
Sources used:
openSUSE Leap 42.2 (src):    xdg-utils-20160610-3.1