Bug 1207369 - velociraptor embeds build date
Summary: velociraptor embeds build date
Status: IN_PROGRESS
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Other (show other bugs)
Version: Current
Hardware: Other All
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Jeff Mahoney
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1047218
  Show dependency treegraph
 
Reported: 2023-01-21 16:04 UTC by Bernhard Wiedemann
Modified: 2023-02-15 19:15 UTC (History)
0 users

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Wiedemann 2023-01-21 16:04:45 UTC
Building the Factory/velociraptor rpm twice results in this diff in the produced binary:

filterdiff strings RPMS*/usr/bin/velociraptor
--- strings RPMS.2017/usr/bin/velociraptor
+++ strings RPMS/usr/bin/velociraptor
@@ -655649,7 +655649,7 @@
 go1.19.5
 /usr/lib64/go/1.19
 call frame too large
-2023-01-21T05:53:04Z
+2023-01-21T05:53:48Z
 3456789:;<=>@ABC
 o~rA
 .`h*
@@ -656015,7 +656015,7 @@
 dep    www.velocidex.com/golang/vfilter        v0.0.0-20221124045546-c666c341aec3
 dep    www.velocidex.com/golang/vtypes v0.0.0-20220816192452-6a27ae078f12
 build  -compiler=gc
-build  -ldflags="-s -w  -X \"www.velocidex.com/golang/velociraptor/config.build_time=2023-01-21T05:53:04Z\" -X \"www.velocidex.com/golang/velociraptor/config.commit_hash=\""
+build  -ldflags="-s -w  -X \"www.velocidex.com/golang/velociraptor/config.build_time=2023-01-21T05:53:48Z\" -X \"www.velocidex.com/golang/velociraptor/config.commit_hash=\""
 build  -tags=server_vql,extras,release,yara,linuxbpf,libbpfgo_full_static
 build  CGO_ENABLED=1
 build  CGO_CFLAGS=
@@ -742898,7 +742898,7 @@
 dep    www.velocidex.com/golang/vfilter        v0.0.0-20221124045546-c666c341aec3
 dep    www.velocidex.com/golang/vtypes v0.0.0-20220816192452-6a27ae078f12
 build  -compiler=gc
-build  -ldflags="-s -w  -X \"www.velocidex.com/golang/velociraptor/config.build_time=2023-01-21T05:53:04Z\" -X \"www.velocidex.com/golang/velociraptor/config.commit_hash=\""
+build  -ldflags="-s -w  -X \"www.velocidex.com/golang/velociraptor/config.build_time=2023-01-21T05:53:48Z\" -X \"www.velocidex.com/golang/velociraptor/config.commit_hash=\""
 build  -tags=server_vql,extras,release,yara,linuxbpf,libbpfgo_full_static
 build  CGO_ENABLED=1
 build  CGO_CFLAGS=


Please either drop the build date or replace it with $SOURCE_DATE_EPOCH
see details in
https://reproducible-builds.org/docs/source-date-epoch/
Comment 2 Bernhard Wiedemann 2023-01-27 11:38:41 UTC
I tested the new version in security:sensor/velociraptor today
and it still has exactly the same problem.

I can see in build.log
export VELOCIRAPTOR_BUILD_TIME=2023-01-24T14:25:07+00:00

but the output still has that diff:
  29d3dc0 7777772e 76656c6f 63696465 782e636f  www.velocidex.co
  29d3dd0 6d2f676f 6c616e67 2f76656c 6f636972  m/golang/velocir
  29d3de0 6170746f 722f636f 6e666967 2e627569  aptor/config.bui
- 29d3df0 6c645f74 696d653d 32303233 2d30312d  ld_time=2023-01-
- 29d3e00 32375431 313a3134 3a34305a 5c22202d  27T11:14:40Z\" -
+ 29d3df0 6c645f74 696d653d 32303339 2d30332d  ld_time=2039-03-
+ 29d3e00 30315430 303a3335 3a30395a 5c22202d  01T00:35:09Z\" -
  29d3e10 58205c22 7777772e 76656c6f 63696465  X \"www.velocide
  29d3e20 782e636f 6d2f676f 6c616e67 2f76656c  x.com/golang/vel
  29d3e30 6f636972 6170746f 722f636f 6e666967  ociraptor/config
Comment 3 OBSbugzilla Bot 2023-02-06 15:15:03 UTC
This is an autogenerated message for OBS integration:
This bug (1207369) was mentioned in
https://build.opensuse.org/request/show/1063430 Factory / velociraptor
Comment 4 Bernhard Wiedemann 2023-02-07 04:21:45 UTC
I retested security:sensor/velociraptor - still is unfixed.

/usr/bin/velociraptor differs in ELF sections
  29d3dc0 7777772e 76656c6f 63696465 782e636f  www.velocidex.co
  29d3dd0 6d2f676f 6c616e67 2f76656c 6f636972  m/golang/velocir
  29d3de0 6170746f 722f636f 6e666967 2e627569  aptor/config.bui
- 29d3df0 6c645f74 696d653d 32303233 2d30322d  ld_time=2023-02-
- 29d3e00 30375430 343a3030 3a33395a 5c22202d  07T04:00:39Z\" -
+ 29d3df0 6c645f74 696d653d 32303339 2d30332d  ld_time=2039-03-
+ 29d3e00 31315431 373a3231 3a31365a 5c22202d  11T17:21:16Z\" -
  29d3e10 58205c22 7777772e 76656c6f 63696465  X \"www.velocide
  29d3e20 782e636f 6d2f676f 6c616e67 2f76656c  x.com/golang/vel
  29d3e30 6f636972 6170746f 722f636f 6e666967  ociraptor/config

It seems, velociraptor-reproducible-timestamp.diff is missing
from velociraptor.spec
Comment 5 Bernhard Wiedemann 2023-02-07 04:42:51 UTC
=> SR 1063543

I confirmed that using velociraptor-reproducible-timestamp.diff made builds reproducible.
Comment 6 OBSbugzilla Bot 2023-02-10 13:35:03 UTC
This is an autogenerated message for OBS integration:
This bug (1207369) was mentioned in
https://build.opensuse.org/request/show/1064242 Factory / velociraptor