Bug 1168281 - Some missing icons
Some missing icons
Status: CONFIRMED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: AutoYaST
Current
Other Other
: P3 - Medium : Normal (vote)
: ---
Assigned To: Sasi Olin
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-01 08:35 UTC by David Diaz
Modified: 2022-07-12 08:37 UTC (History)
4 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Screenshot where it can be seen some missing icons (128.07 KB, image/png)
2020-04-01 08:35 UTC, David Diaz
Details
(Not accurated) missing YaST SVG icons list (1.18 KB, text/plain)
2020-04-03 10:48 UTC, David Diaz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Diaz 2020-04-01 08:35:04 UTC
Created attachment 834469 [details]
Screenshot where it can be seen some missing icons

Hi there!

Seems that YaST lost some icons when moving them from `yast-theme` to each YaST module[1][2][3]. I prepared a PR to bring them back[4], but only their PNG versions.

@Stasiek, do you mind to prepare their SVG versions?

Thanks in advance.

[1] https://bugzilla.opensuse.org/show_bug.cgi?id=1109310
[2] https://github.com/yast/yast-theme/commit/afa341066b9851808fbaa25756470cd119d41bfd
[3] https://github.com/yast/yast-autoinstallation/commit/2eb1e8e734828f5cb325bd07f581729cbd011664
[4] https://github.com/yast/yast-autoinstallation/pull/577
Comment 1 David Diaz 2020-04-03 10:33:36 UTC
Hi all!

First of all, thanks a lot for creating the requested SVG versions, which were added in https://github.com/yast/yast-autoinstallation/pull/578

Sadly, two more missing icons were detected,

  * yast-deploy_image[1]
  * yast-ssh-server[2]

Do you mind to create them as well?

Thanks in advance.


[1] https://github.com/yast/yast-theme/blob/a4b1d6b489e31b8ddc75b267c3fef242f1a4ecb4/icons/hicolor/48x48/apps/yast-deploy_image.png
[2] https://github.com/yast/yast-theme/blob/a4b1d6b489e31b8ddc75b267c3fef242f1a4ecb4/icons/hicolor/48x48/apps/yast-ssh-server.png
Comment 2 David Diaz 2020-04-03 10:47:01 UTC
BTW, to avoid doing many request to this regard, I tried to figure out the total amount of missing icons. To do so, I followed these steps

  * Look for `yast*.png` icons in `yast-theme#a4b1d6b4:icons/hicolor/48x48` (140 results)
  * Look for `yast*.svg` files in all repos of YaST organization[1] (154 results)
  * Calculate missing SVGs (79 results, see attached file)

However, those results are not accurate/userful enough since some icons were actually renamed[2]. E.g, yast-partitioning is now yast-disk. Do you have any list or document with those changes? If not, don't worry, we can add missing icons as we find them.

Thanks!
   

[1] https://github.com/search?q=org%3Ayast+filename%3Ayast*.svg&type=Code 
[2] https://bugzilla.suse.com/show_bug.cgi?id=1110236#c0
Comment 3 David Diaz 2020-04-03 10:48:40 UTC
Created attachment 834819 [details]
(Not accurated) missing YaST SVG icons list
Comment 4 Sasi Olin 2020-04-03 11:04:37 UTC
(In reply to David Diaz from comment #1)
> Hi all!
> 
> First of all, thanks a lot for creating the requested SVG versions, which
> were added in https://github.com/yast/yast-autoinstallation/pull/578
> 
> Sadly, two more missing icons were detected,
> 
>   * yast-deploy_image[1]
>   * yast-ssh-server[2]

For the future LCP, both for https://github.com/yast/yast-installation, but the name is wrong, because importing ssh keys isn't ssh-server.

(In reply to David Diaz from comment #3)
> Created attachment 834819 [details]
> (Not accurated) missing YaST SVG icons list

Most of those don't have any mentions in the yast org on github, are you sure about that? You can search with:
https://github.com/search?q=org%3Ayast&type=Code
Comment 5 David Diaz 2020-04-03 12:33:34 UTC
(In reply to Stasiek Michalski from comment #4)
> (In reply to David Diaz from comment #1)
> > Hi all!
> > 
> > First of all, thanks a lot for creating the requested SVG versions, which
> > were added in https://github.com/yast/yast-autoinstallation/pull/578
> > 
> > Sadly, two more missing icons were detected,
> > 
> >   * yast-deploy_image[1]
> >   * yast-ssh-server[2]
> 
> For the future LCP, both for https://github.com/yast/yast-installation, 

Good point, sorry.

> but
> the name is wrong, because importing ssh keys isn't ssh-server.

Totally agree.

> 
> (In reply to David Diaz from comment #3)
> > Created attachment 834819 [details]
> > (Not accurated) missing YaST SVG icons list
> 
> Most of those don't have any mentions in the yast org on github, are you
> sure about that? You can search with:
> https://github.com/search?q=org%3Ayast&type=Code

I'm sure that those icons were there[1], but not if they still being in use. That's why probably we should forget about them and reintroduce only those reported as missing. I simply had curiosity about if we had a list with the correspondence of changed icons.

[1] https://github.com/yast/yast-theme/commit/afa341066b9851808fbaa25756470cd119d41bfd
Comment 12 Swamp Workflow Management 2020-05-22 22:31:00 UTC
openSUSE-SU-2020:0676-1: An update that solves one vulnerability and has 6 fixes is now available.

Category: security (moderate)
Bug References: 1109310,1133045,1140711,1164105,1168123,1168281,1170082
CVE References: CVE-2019-18905
Sources used:
openSUSE Leap 15.1 (src):    autoyast2-4.1.15-lp151.2.12.1