Bug 1162535 - Update openSUSE Plymouth theme for 15.2 to bgrt
Update openSUSE Plymouth theme for 15.2 to bgrt
Status: RESOLVED FIXED
: 1164073 (view as bug list)
Classification: openSUSE
Product: openSUSE Distribution
Classification: openSUSE
Component: Basesystem
Leap 15.2
Other Other
: P2 - High : Normal (vote)
: ---
Assigned To: Cliff Zhao
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-02-03 17:46 UTC by Sasi Olin
Modified: 2022-08-22 16:43 UTC (History)
10 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sasi Olin 2020-02-03 17:46:04 UTC
Following Tumbleweed, change the line setting the default theme to `sed -i -e 's/spinner/bgrt/g' src/plymouthd.defaults`
Comment 1 Max Lin 2020-02-12 14:07:32 UTC
Hi qzhao, can you take care of this?
Comment 2 Swamp Workflow Management 2020-02-12 14:50:05 UTC
This is an autogenerated message for OBS integration:
This bug (1162535) was mentioned in
https://build.opensuse.org/request/show/773727 Factory / livecd-openSUSE
Comment 3 Cliff Zhao 2020-02-17 12:49:58 UTC
Hi Stasiek:
Yes, it is an enhancement.
but Leap-15.2 has already released, it only accept bug-fix.
this action will only be taken when there has any error on bgrt.
Thanks!
Comment 4 Cliff Zhao 2020-02-17 12:56:56 UTC
has any error on default, sorry.
Comment 5 Max Lin 2020-02-17 15:29:34 UTC
Hi,

(In reply to Cliff Zhao from comment #3)
> Hi Stasiek:
> Yes, it is an enhancement.
> but Leap-15.2 has already released, it only accept bug-fix.

Leap 15.2 isn't released, we are approach to Beta phrase though.

> this action will only be taken when there has any error on bgrt.
> Thanks!

Since the relevant branding-openSUSE change already merged to Leap 15.2, setting the default theme path is invalid in plymouth to use the old/wrong path, if you need a bugreference for submit a request to SLE you can just use this one.
Comment 6 Cliff Zhao 2020-02-18 15:12:40 UTC
(In reply to Max Lin from comment #5)
> Since the relevant branding-openSUSE change already merged to Leap 15.2,
> setting the default theme path is invalid in plymouth to use the old/wrong
> path, if you need a bugreference for submit a request to SLE you can just
> use this one.
Sorry, by a glance on the branding-openSUSE, I find it installs a watermark.png for the Plymouth, but you said that it changes the default theme path, could you please point where should I pay special attention to?s
and the Plymouth don't need a path to assign theme generally. Maybe there have something in the release side I don't know, I'm confused.

but there has limited times before released, I will do it. anyway.
Comment 7 Cliff Zhao 2020-02-18 15:30:14 UTC
Another thing is, This is obviously a temporary fix that will have to be changed back later.
Comment 8 Max Lin 2020-02-18 16:00:06 UTC
Last change in branding-openSUSE is [1] which basically obsoletes old openSUSE theme, that is why you only see watermark.png in plymouth-branding-openSUSE, if you grab a old plymouth-branding-openSUSE from previous Leap 15, eg. 15.1, 1.50, you will find those *.png files, and so https://build.opensuse.org/package/view_file/openSUSE:Leap:15.2/plymouth/plymouth.spec?expand=1 line#366 - sed -i -e 's/spinner/openSUSE/g' src/plymouthd.defaults is just not work - a bug, because set-default-theme will parse the content of plymouthd.defaults.

Following with [1], plymouth should use bgrt as the default theme on openSUSE as same as Tumbleweed had already(see the subject - Update openSUSE Plymouth theme for 15.2 to bgrt). Branding maintainer have created a corresponding requqest[2] however plymouth is from SLE therefore he created this bugreport instead, so we would please plymouth maintainer submit a plymouth update to SLE with the same change like [2] do. BTW plymouth-theme-bgrt is generated from plymouth package itself.

And no, it's not a temporary fix that we will change it back later. I hope this helps clarify the situation. Additional information, the change we needed in plymouth is under %if 0%{?is_opensuse}, it should not affect SLE side in case you have any concern about that.


[1] https://build.opensuse.org/request/show/769402
[2] https://build.opensuse.org/request/show/769401
Comment 9 Cliff Zhao 2020-02-19 08:25:01 UTC
Hi Max:
In the maintain editions of SLE, I saw that SLE has already changed the default theme to bgrt when I branch the Plymouth source code, but the official repo kept in the openSUSE theme. I suppose someone has already submitted the change but in the maintenance working flow. Is that you? and is there anything else you need me to do from the SLE side?
another thing is I found the Plymouth source in openSUSE-Leap-15.2 is far behind any maintenance source in SLE-15, Do you want to submit the Plymouth from SUSE:SLE-15-SP1:Update to openSUSE:Leap:15.2?

and yesterday my VPN has broken, so I can't access IBS. today, I contact the IT colleague, and fixed. Sorry for the delay.
Comment 10 Max Lin 2020-02-19 09:02:12 UTC
After a chat with Cliff, indeed, there is a pending maint update(created 5 months ago) that updated plymouth to 0.9.5, which changed the default theme to bgrt also[1], however it seemed maint update hasn't released.


$ iosc maintained plymouth
SUSE:SLE-12-SP2:Update/plymouth
SUSE:SLE-12:Update/plymouth using sources from SUSE:Maintenance:11740/plymouth.SUSE_SLE-12_Update
SUSE:SLE-15-SP1:Update/plymouth using sources from SUSE:Maintenance:12798/plymouth.SUSE_SLE-15-SP1_Update
SUSE:SLE-15:Update/plymouth using sources from SUSE:Maintenance:12265/plymouth.SUSE_SLE-15_Update

[1] https://build.suse.de/request/show/201585

Hi Marcus,

Any idea why did SUSE:Maintenance:12798 hasn't released?
Comment 11 Marcus Meissner 2020-02-19 13:16:37 UTC
The problem is it does not build, it also cvhanges library major versions.

This version update request should have better be for SUSE:SLE-15-SP2:GA

Also %autosetup -S git   fails, which is more annyoing.

Cliff Zhao,

can you fix the build issues?

FOR SLES 15 SP1 we would like to have a more minimal submission.

The full submission could still be tried for SUSE:SLE-15-SP2:GA, but its very very late in the process and might not go in.
Comment 12 Neil Rickert 2020-02-19 21:24:23 UTC
I'm not sure if this is the place to report it.

Plymouth is giving me problems with Leap 15.2 Build 577.2

I get only the text screen from plymouth (3 green dots).  And it boots to a blank screen (no login screen is showing).  I can then get to a command line with CTRL-ALT-F1.  Perhaps I can get a login screen with CTRL-ALT-F7 (seemed to work on one system, but not on another).

If I remove "splash=silent" from the kernel command line, then it boots normally to the GDM login screen.
Comment 13 Cliff Zhao 2020-02-20 05:58:17 UTC
(In reply to Marcus Meissner from comment #11)
> The problem is it does not build, it also cvhanges library major versions.
> This version update request should have better be for SUSE:SLE-15-SP2:GA
> Also %autosetup -S git   fails, which is more annyoing.
> Cliff Zhao,
> can you fix the build issues?

Hi Marcus:
Do you mean request in "https://build.suse.de/request/show/201584"?
Because I saw the building result succeeded in IBS web site and when I local building against SUSE:SLE-15:Update it also succeeded. I guess maybe it can't be build from the maintenance side, or there has some information I don't know?

For the library version problem: 
There hass no big API change in so level, everything works as normal, upstream just use two-step support UEFI logo, so they think they change the so vertion then, we as the  downstream only can follow up. and there's no other package linked to plymouth's library. So please don't worry, there is no risk. I supposed release managers knows all the backgroud, if you have doubt, please ask me once without any hesitate.

For it's better to release in SUSE:SLE-15-SP2:GA: 
In fact, this version of soure code has already released in SUSE:SLE-15-SP1, so I think it is not a special point in SUSE:SLE-15-SP2:GA. and I think that the thing which related to this bug is the Plymouth in Leap 15.2 far behind these 2 maintenance Plymouth sources which inside SLE-15 repos. I think maybe we need to update Leap or some else actions.

For %autosetup -S git fails,  which is more annyoing.
Where can I find the failures?

> 
> FOR SLES 15 SP1 we would like to have a more minimal submission. 
> The full submission could still be tried for SUSE:SLE-15-SP2:GA, but its
> very very late in the process and might not go in.

Sorry, I'm afraid I haven't mastered the full relationship between your meanings and my work:
The Plymouth maintenance update is on SUSE:SLE-15:Update. The SUSE:SLE-15-SP1 repo have already had these code in the time point when it released, I mean if some day, SUSE:SLE-15:Update accept and release plymouth's maintenance modification, then plymouth's source will be totally the same between SUSE:SLE-15:Update and SUSE:SLE-15-SP1:GA and SUSE:SLE-15-SP1:Update. Current situation is the plymouth in SUSE:SLE-15-SP1:GA and SUSE:SLE-15-SP1:Update don't have the build failures there. Do you mean you want me to fix the "%autosetup -S git" because it's very annyoing and may have bad depending effects in the future? Am I understanding correctly? it's ok for me.
Comment 14 Cliff Zhao 2020-02-20 06:07:46 UTC
(In reply to Neil Rickert from comment #12)
> I'm not sure if this is the place to report it.
> 
> Plymouth is giving me problems with Leap 15.2 Build 577.2
> 
> I get only the text screen from plymouth (3 green dots).  And it boots to a
> blank screen (no login screen is showing).  I can then get to a command line
> with CTRL-ALT-F1.  Perhaps I can get a login screen with CTRL-ALT-F7 (seemed
> to work on one system, but not on another).
> 
> If I remove "splash=silent" from the kernel command line, then it boots
> normally to the GDM login screen.

Sorry, I'm afraid not. please open another bug and tell me the reproduce steps.
the "3 green dots" animation is the Plymouth's fallback mode. 
In order to not disturb the mainline discussion of this bug, That's all the thins I can say here. Sorry.
Comment 15 Cliff Zhao 2020-02-20 06:13:22 UTC
(In reply to Neil Rickert from comment #12)
> I'm not sure if this is the place to report it.
> 
> Plymouth is giving me problems with Leap 15.2 Build 577.2
> 
> I get only the text screen from plymouth (3 green dots).  And it boots to a
> blank screen (no login screen is showing).  I can then get to a command line
> with CTRL-ALT-F1.  Perhaps I can get a login screen with CTRL-ALT-F7 (seemed
> to work on one system, but not on another).
> 
> If I remove "splash=silent" from the kernel command line, then it boots
> normally to the GDM login screen.

Sorry, I'm afraid not. please open another bug and tell me your steps of how you meet it. The "3 green dots" animation is Plymouth's fallback mode. 
In order to not disturb the mainline discussion of this bug, That's all the things I can say here. 
Sorry for the typo!
Comment 16 Guillaume GARDET 2020-02-20 07:02:48 UTC
*** Bug 1164073 has been marked as a duplicate of this bug. ***
Comment 17 Lubos Kocman 2020-06-03 08:17:13 UTC
Reducing priority to P2. Update request should not be P1, unless crash is involved.
Comment 18 Cliff Zhao 2020-06-19 16:13:48 UTC
*** Bug 1164073 has been marked as a duplicate of this bug. ***
Comment 19 Lubos Kocman 2020-09-01 11:22:02 UTC
Hello team,

here are the build issues on x86_64 from https://build.suse.de/request/show/201585

(you have to click on the questionmark button as it fails before the build is initiated)
"""
The build can not begin, because required packages are either missing or not explicitly defined.

 Build jobs have been processed, new repository is not yet created
unresolvable: have choice for pkgconfig(cairo): cairo-devel cairo-devel-32bit, have choice for pkgconfig(libdrm): libdrm-devel libdrm-devel-32bit, have choice for pkgconfig(pango) >= 1.21.0: pango-devel pango-devel-32bit
"""

Cliff this seems to be the only last issue blocking the release.
Comment 20 Frederic Crozat 2020-09-01 12:52:40 UTC
(In reply to Lubos Kocman from comment #19)
> Hello team,
> 
> here are the build issues on x86_64 from
> https://build.suse.de/request/show/201585

You can't rely on those, it is building against Factory mirror, not against SLE15 SP1