Bug 1161136 - bash completion for adb is obsolete and should be removed and cause problems
bash completion for adb is obsolete and should be removed and cause problems
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Other
Current
Other Other
: P5 - None : Enhancement (vote)
: ---
Assigned To: Dr. Werner Fink
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-01-17 00:01 UTC by Michael Pujos
Modified: 2020-02-14 10:24 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---
werner: needinfo? (pujos.michael)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pujos 2020-01-17 00:01:09 UTC
bash-completion package contains a completion file for command adb:

/usr/share/bash-completion/completions/_adb

This file starts with a statement about it being obsolete.

Not only that, but it makes useful file expansion impossible.
For example, this does not work (no file completion):

adb install <TAB>

So it should be removed from bash-completion as it does more harm than good.
Comment 1 Dr. Werner Fink 2020-01-17 07:08:00 UTC
(In reply to Michael Pujos from comment #0)
> bash-completion package contains a completion file for command adb:
> 
> /usr/share/bash-completion/completions/_adb
> 
> This file starts with a statement about it being obsolete.
> 
> Not only that, but it makes useful file expansion impossible.
> For example, this does not work (no file completion):
> 
> adb install <TAB>
> 
> So it should be removed from bash-completion as it does more harm than good.

I'd like to know why upstream use them at all if so.

Please report it upstream as well!
Comment 2 Swamp Workflow Management 2020-01-17 10:30:06 UTC
This is an autogenerated message for OBS integration:
This bug (1161136) was mentioned in
https://build.opensuse.org/request/show/765174 Factory / bash-completion
Comment 3 Dr. Werner Fink 2020-02-14 10:24:53 UTC
(In reply to Swamp Workflow Management from comment #2)
> This is an autogenerated message for OBS integration:
> This bug (1161136) was mentioned in
> https://rudin.suse.de:8894/request/show/765174 Factory / bash-completion