Bugzilla – Bug 1160256
argyllcms fails with -fno-common
Last modified: 2021-10-12 18:45:40 UTC
The package fails here: https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:M/argyllcms/standard/x86_64 Please take a look at the META package for the instructions.
*META issue
May I please ping this issue?
May I please ping this as we're slowly (but surely) approaching a new GCC release and this will unblock acceptance of the new package into Factory.
I updated to version 2.1.2. Still affected. In this case, there was combination of two problems: - The header problem described in bug 1160244. Local variables defined without "static" were conflicting with local variables of another file with the same problem. I made a fix and sent it to the upstream maintainer Graeme Gill. https://build.opensuse.org/request/show/781709
Upstream rejected part of my patch: Hi, > Index: Argyll_V2.1.2/gamut/gamut.h > =================================================================== > --- Argyll_V2.1.2.orig/gamut/gamut.h > +++ Argyll_V2.1.2/gamut/gamut.h > @@ -36,7 +36,7 @@ > #define MAXGAMN 10 /* Maximum gamut point neighbors returned */ > #define NSLOTS 6 /* Number of maximum direction slots */ > > -struct _vrml *wrl; /* Declared in vrml.h, which may be #included after this */ > +extern struct _vrml *wrl; /* Declared in vrml.h, which may be #included after this */ > > /* ------------------------------------ */ > #define NODE_STRUCT This is a bug. The declaration should simply be: struct _vrml; Fixed via https://build.opensuse.org/request/show/783130