Bug 1155700 - Git Cola 3.5 crashes on repo open (edit)
Git Cola 3.5 crashes on repo open (edit)
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: X11 Applications
Current
x86-64 Other
: P5 - None : Normal (vote)
: ---
Assigned To: Marcin Bajor
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2019-11-03 20:22 UTC by Aleksey Kontsevich
Modified: 2019-12-28 22:08 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksey Kontsevich 2019-11-03 20:22:44 UTC
Git Cola began to crash on repo open again:

```
> git-cola
Traceback (most recent call last):
  File "/usr/share/git-cola/lib/cola/fsmonitor.py", line 198, in run
    self._inotify_fd = inotify.init()
  File "/usr/share/git-cola/lib/cola/inotify.py", line 44, in _errcheck
    raise OSError(err, os.strerror(err))
OSError: [Errno 24] Too many open files
Aborted (core dumped)
```

Could You update to latest version from github master please to check if it fixes the problem? Thanks!

https://github.com/git-cola/git-cola/issues/991#issuecomment-549161703
Comment 1 Marcin Bajor 2019-11-03 21:34:49 UTC
Waiting for git-cola developer author response.

I think this is system settings issue and may be fixed(temporary) by adding below 2 lines to /etc/security/limits.conf:
* soft nofile 4096
* hard nofile 4096
Pleas reboot system. 

Please check your current settings with terminal command:
ulimit -n

Probably your current setting is 1024
Comment 2 Aleksey Kontsevich 2019-11-04 00:06:11 UTC
(In reply to Marcin Bajor from comment #1)
> Waiting for git-cola developer author response.
Ok. Thanks. However there are other crash fixes in latest master related to branches model, which still exists in suse rpms. Please update. Could You make automatic updates for the package on git-cola new commits please as author do no update version number, please? Thanks!
 
> I think this is system settings issue and may be fixed(temporary) by adding
> below 2 lines to /etc/security/limits.conf:
> * soft nofile 4096
> * hard nofile 4096
> Pleas reboot system. 
Yes, this helps, thanks!

> Probably your current setting is 1024
Yes, was.
Comment 3 Aleksey Kontsevich 2019-11-20 16:18:15 UTC
Any updates on this? Could You update the package to latest sources version on Github please? Still crashes on branch change, etc which were fixed there.

Referenced this issue here: https://github.com/git-cola/git-cola/issues/1015
Comment 4 Marcin Bajor 2019-11-20 17:44:30 UTC
Aleksey, I don't want to submit packages which are not released as stable.
Note that each update to official repository needs review. This take a time.
I want to avoid a situation where the very unstable version is in the repository. The release of the next, fixed version takes some time again.

I can update
https://build.opensuse.org/package/show/devel:tools:scm/git-cola
with latest version from github.
Comment 5 Aleksey Kontsevich 2019-11-20 18:46:58 UTC
(In reply to Marcin Bajor from comment #4)
> Aleksey, I don't want to submit packages which are not released as stable.
> Note that each update to official repository needs review. This take a time.
> I want to avoid a situation where the very unstable version is in the
> repository. The release of the next, fixed version takes some time again.

Author said to me it is stable and he won't change version for this updates:
https://github.com/git-cola/git-cola/issues/997#issuecomment-538866309

> I can update
> https://build.opensuse.org/package/show/devel:tools:scm/git-cola
> with latest version from github.

Thanks much! Will download from there. Ping when ready please.
Comment 6 Marcin Bajor 2019-11-20 19:12:16 UTC
You can download v3.5.91.ga5fe1820
Comment 7 Aleksey Kontsevich 2019-11-20 19:49:34 UTC
(In reply to Marcin Bajor from comment #6)
> You can download v3.5.91.ga5fe1820

Thanks much! Done, works fine!
Comment 8 Marcin Bajor 2019-12-28 22:08:07 UTC
Patched version has been submitted and is available in the repository