Bug 1155674 - Expert Partitioner: internal error, if encrypted btrfs partition shall be created
Expert Partitioner: internal error, if encrypted btrfs partition shall be cre...
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Installation
x86-64 Other
: P5 - None : Normal (vote)
: ---
Assigned To: E-mail List
Jiri Srain
Depends on:
  Show dependency treegraph
Reported: 2019-11-01 23:52 UTC by Maik Köhler
Modified: 2020-01-07 15:31 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Result of save_y2logs (1.32 MB, application/x-xz)
2019-11-01 23:52 UTC, Maik Köhler
The wrong (de) translation for the Encrypt widget's help (30.92 KB, image/png)
2019-11-04 17:27 UTC, David Diaz

Note You need to log in before you can comment on or make changes to this bug.
Description Maik Köhler 2019-11-01 23:52:16 UTC
Created attachment 823065 [details]
Result of save_y2logs

The Installer of the GNOME Live CD (Snapshot 20191030) produces an error during the creation of an encrypted btrfs subvolume, if the expert partitioner is used.

My goal is to reuse the existing EFI partitioning of the Windows 10 install to dual boot - the guided partitioning scheme intends to create a new EFI partition. (not a deal breaker, but IMHO it should be possible to create an encrypted btrfs partition using the export route)

Reproducible: always

Steps to reproduce:
 1. Boot GNOME Live CD (Snapshot 20191030)
 2. Start Installation
 3. During Partitioning choose "Expert"
 4. Create a new partition
 5. Choose format as btrfs, mount point /, enable subvolume creation
 6. Choose to encrypt the partition
 7. Click Next
 8. Installer produces the following error message: 

  Caller:  /usr/share/YaST2/lib/y2partitioner/widgets/encrypt.rb:92:in `format'
  Details: key{Header} not found

Expected result:
Installer allows creation of custom partition with encrypted btrfs partition.

Interestingly *not* choosing the expert partitioning and choosing to install with encryption works, if selected in the guided setup. (put does not produce the wanted custom partitioning scheme)

I have attached a log produced by save_y2logs.

I couldn't find an existing bug report and hope, that the information is useful.
Comment 1 David Diaz 2019-11-04 17:25:39 UTC
Thanks for the report Maik!

I'm happy to say that, fortunately, there is "nothing" wrong with the expert partitioner. Actually, the problem is in the German translations, and it is quite easy to fix.

The technical/long explanation: to build and show the help for the Encrypt[1] widget, we are using named parameters[2] (e.g., %{header}), which must be not changed by translators. But, likely by mistake, they were translated[see the screenshot]... and that's why Ruby is complaining.

[1] https://github.com/yast/yast-storage-ng/blob/bb65229236ab87a0fc01aa49ebd169468fc1ccb7/src/lib/y2partitioner/widgets/encrypt.rb
[2] https://yastgithubio.readthedocs.io/en/latest/localization/#using-named-parameters
Comment 2 David Diaz 2019-11-04 17:27:08 UTC
Created attachment 823284 [details]
The wrong (de) translation for the Encrypt widget's help
Comment 3 David Diaz 2019-11-04 17:31:29 UTC
I fix the translation through the Weblate[1], but I am not sure if it is enough. So, reassigning the report.

Comment 5 Ancor Gonzalez Sosa 2020-01-07 15:31:20 UTC
The fixed translation was merged into the yast-trans repository on November 4th[1] and accepted into Factory on December 9th[2]. So this should be already fixed in Tumbleweed.

[1] https://github.com/yast/yast-translations/commit/d05f35e25d2231110bf6e231ba68343d14516e48#diff-ba132e4893e5d16273a165c8de165665
[2] https://build.opensuse.org/request/show/755106