I just encountered a problem with activation of smartd_generate_opts.path:
- Path trigger works in fresh installation.
- Path trigger does not work on upgrade.

As everything seems to be correctly set up in the smartmontools package and in the systemd-presets-common-SUSE, I suppose that something is broken for .path files in the %service_add_post macro.


Details:

In past, Thorsten created smartd_generate_opts.path and smartd_generate_opts.service that should automatically activate /usr/lib/smartmontools/generate_smartd_opts whenever /etc/sysconfig/smartmontools changes.

It works perfectly on a fresh installation, but it seems to be broken on upgrade.

I was thinking that the correct solution is adding of
enable smartd_generate_opts.path
to /usr/lib/systemd/system-preset/95-default-SUSE.preset

But it was done.


How to reproduce:

Test 1 (works on fresh installation):

1) Make a fresh installation of Tumbleweed
(Note, in case of testing on virtual, you have to delete ConditionVirtualization=false from /usr/lib/systemd/system/smartd.service and add "-q never" to SMARTD_EXTRA_OPTS in /etc/sysconfig/smartmontools).

2) Edit /etc/sysconfig/smartmontools and start smartd (if needed).

Current result:
smartd is instantly restarted. = OK

Test 2 (broken on upgrade):

1) rpm -e smartmontools

2) Install any older version of smartmontools.

3) zypper in smartmontools (see note on virtualization above).

4) Edit /etc/sysconfig/smartmontools and start smartd (if needed).

Current result:
smartd is left intact. = BROKEN

Work-around:
systemctl enable smartd_generate_opts.path
systemctl start smartd_generate_opts.path


Notes:

When it starts to work, then
## Command:     /usr/lib/smartmontools/generate_smartd_opts
in /etc/sysconfig/smartmontools will become obsolete.

It makes sense to add ConditionVirtualization=false to smartd_generate_opts.service or smartd_generate_opts.path, as it is present in the main smartd.service.