Bug 1143616 – Fillup templates seem to be broken

Bug 1143616 - Fillup templates seem to be broken


Summary:	Fillup templates seem to be broken

Status:	CONFIRMED

Classification:	openSUSE
Product:	openSUSE Tumbleweed
Classification:	openSUSE
Component:	Basesystem
Version:	Current
Hardware:	Other Other

Priority:	P5 - None Severity: Normal (vote)
Target Milestone:	---
Assigned To:	Adam Majer
QA Contact:	E-mail List

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Create test case

Clone This Bug

Reported:	2019-07-31 11:21 UTC by Andreas Schneider
Modified:	2019-08-07 14:43 UTC (History)
CC List:	4 users (show)

See Also:
Found By:	---
Services Priority:
Business Priority:
Blocker:	---
Marketing QA Status:	---
IT Deployment:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Schneider 2019-07-31 11:21:53 UTC

I've created a fillup template but it doesn't seem to be possible to install it. All I get is a very strange error:

magrathea:~ # /bin/fillup -q /etc/sysconfig/prometheus /usr/share/fillup-templates/sysconfig.prometheus
        fillup: Exception in ../SRC/services.c, line 348 concerning file not opened


https://build.opensuse.org/request/show/720033

Comment 1 Thorsten Kukuk 2019-07-31 12:40:24 UTC

touch /etc/sysconfig/prometheus
is most likely missing. See the fillup macro how it is called.

Comment 2 Andreas Schneider 2019-07-31 14:23:03 UTC

I've fixed it. I needs to be

%fillup_only -n prometheus


However the error is quite strange. A better error message would be nice :-)

Comment 3 Adam Majer 2019-08-07 14:43:50 UTC

The problem is basically just lack of quoting in fillup_exception() (SRC/services.c:185). Instead of

   fillup: Exception in ../SRC/services.c, line 348 concerning file not opened

it should be,

  fillup: Exception in '../SRC/services.c', line 348 concerning 'file not opened'