Bug 1143558 – scrollbar resets when selecting role

Bug 1143558 - scrollbar resets when selecting role


Summary:	scrollbar resets when selecting role

Status:	RESOLVED FIXED

Classification:	openSUSE
Product:	openSUSE Tumbleweed
Classification:	openSUSE
Component:	YaST2
Version:	Current
Hardware:	Other Other

Priority:	P5 - None Severity: Normal (vote)
Target Milestone:	---
Assigned To:	YaST Team
QA Contact:	Jiri Srain

URL:	https://trello.com/c/YNjBYHWY
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Create test case

Clone This Bug

Reported:	2019-07-31 08:01 UTC by Arvin Schnell
Modified:	2022-02-24 14:52 UTC (History)
CC List:	4 users (show)

See Also:
Found By:	Development
Services Priority:
Business Priority:
Blocker:	---
Marketing QA Status:	---
IT Deployment:	---

Attachments
screenshot before selecting role (98.55 KB, image/png) 2019-07-31 08:02 UTC, Arvin Schnell	Details
YaST logs files (69.81 KB, application/x-xz) 2019-07-31 08:02 UTC, Arvin Schnell	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Arvin Schnell 2019-07-31 08:01:28 UTC

In the dialog to select the role I have to scroll down to see all roles.
When I then select a role the scrollbar jumps back to the top and the
selected role is not even visible anymore.

Comment 1 Arvin Schnell 2019-07-31 08:02:01 UTC

Created attachment 812237 [details]
screenshot before selecting role

Comment 2 Arvin Schnell 2019-07-31 08:02:35 UTC

Created attachment 812238 [details]
YaST logs files

Comment 3 José Iván López González 2019-07-31 08:33:13 UTC

Martin, please, could you have a look? I am not sure if this is something we can easily fix. Thanks.

Comment 4 Martin Vidner 2019-07-31 08:44:38 UTC

Thanks for the report.

Yes. It's because libyui has no concept of a scrollable VBox.

Therefore we simulate one with a RichText widget[1]. When you select a role, we have to replace the text to put the selected "radio button" in the right place. Replacing resets the scroll bar.

[1]: https://github.com/yast/yast-installation/blob/b7e93db8a3223d3d47e989e491348f2761c07430/src/lib/installation/select_system_role.rb#L270

Comment 5 Martin Vidner 2019-07-31 08:50:01 UTC

One way to fix this would be adding a scrollable VBox to libyui. We can add it to the backlog and do it, because we have seen sometimes it is needed.

Comment 6 Arvin Schnell 2019-07-31 08:52:16 UTC

We could also make the RichText widget remember the scrollbar when setting
new content.

Comment 7 Ancor Gonzalez Sosa 2019-12-02 12:04:46 UTC

This is now fixed. See https://github.com/yast/yast-installation/pull/827