Bug 1113945 - texinfo build fails in openSUSE:Factory:Staging:C
texinfo build fails in openSUSE:Factory:Staging:C
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: Dr. Werner Fink
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-30 12:46 UTC by Martin Liška
Modified: 2018-10-30 13:50 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Liška 2018-10-30 12:46:54 UTC
It's caused by multiple tests failing due to:

...
1,2d0
< Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/^\s+@([[:alnum:]][[:alnum:]\-]*)({ <-- HERE })?\s*/ at ../../tp/Texinfo/Parser.pm line 5481.
< Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/^\s+@([[:alnum:]][[:alnum:]\-]*)({ <-- HERE })?\s*(\@(c|comment)((\@|\s+).*)?)?/ at ../../tp/Texinfo/Parser.pm line 5485.
FAIL t/stdout_split.sh (exit status: 1)
...

Can you please fix the regex?
Comment 1 Dr. Werner Fink 2018-10-30 12:59:30 UTC
Would you pelayse explain where it does fail as I see on Tumbleweed

[  131s] PASS: test_scripts/layout_formatting_chm.sh
[  131s] PASS: test_scripts/layout_formatting_nodes.sh
[  131s] PASS: t/stdout.sh
[  131s] PASS: t/stdout_split.sh
[  131s] ============================================================================
[  131s] Testsuite summary for GNU Texinfo 6.5
[  131s] ============================================================================
[  131s] # TOTAL: 184
[  131s] # PASS:  171
[  131s] # SKIP:  13
[  131s] # XFAIL: 0
[  131s] # FAIL:  0
[  131s] # XPASS: 0
[  131s] # ERROR: 0
Comment 2 Martin Liška 2018-10-30 13:00:46 UTC
(In reply to Dr. Werner Fink from comment #1)
> Would you pelayse explain where it does fail as I see on Tumbleweed

In following staging project: openSUSE:Factory:Staging:C
Comment 3 Dr. Werner Fink 2018-10-30 13:05:17 UTC


  } elsif ($command eq 'clickstyle') {
    # REMACRO
    if ($line =~ /^\s+@([[:alnum:]][[:alnum:]\-]*)({})?\s*/) { # <<< line 5481
      $args = ['@'.$1];
      $self->{'clickstyle'} = $1;
      $remaining = $line;
      $remaining =~ s/^\s+@([[:alnum:]][[:alnum:]\-]*)({})?\s*(\@(c|comment)((\@|\s+).*)?)?//; # <<< line 5485
      $has_comment = 1 if (defined($4));
    }

and what is wrong here with {} in Perl 5.32
Comment 5 Dr. Werner Fink 2018-10-30 13:14:25 UTC
When will perl upstream ever learn not to break the API within minor version updates ... this break seems to happen with perl 5.28
Comment 6 Martin Liška 2018-10-30 13:16:47 UTC
(In reply to Dr. Werner Fink from comment #5)
> When will perl upstream ever learn not to break the API within minor version
> updates ... this break seems to happen with perl 5.28

Fully agree with that minor version should not break it!
Comment 7 Dr. Werner Fink 2018-10-30 13:18:13 UTC
SR#645535
Comment 8 Martin Liška 2018-10-30 13:33:17 UTC
(In reply to Dr. Werner Fink from comment #7)
> SR#645535

Thanks for the super-fast fix.
Comment 9 Swamp Workflow Management 2018-10-30 13:50:05 UTC
This is an autogenerated message for OBS integration:
This bug (1113945) was mentioned in
https://build.opensuse.org/request/show/645535 Factory / texinfo