Bug 1098191 - doxywizard will not build with qt 5.11
doxywizard will not build with qt 5.11
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: KDE Applications
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: Petr Gajdos
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-06-19 10:01 UTC by Petr Gajdos
Modified: 2018-06-19 13:18 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
Patch to fix build (1.17 KB, patch)
2018-06-19 10:52 UTC, Christophe Giboudeaux
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Gajdos 2018-06-19 10:01:10 UTC
Following patch does fixes the build for Tumbleweed:
https://build.opensuse.org/package/view_file/devel:tools/doxygen/doxywizard-qt-5.11.patch?expand=1
Comment 1 Petr Gajdos 2018-06-19 10:13:42 UTC
However, I would like to ask you, Luca and Michal:

Is this patch correct for qt 5.11?

If yes, can it be base for upstream patch? I mean: will this work for older Qt5 than 5.11? It is clear qt_use_modules macro definition will be redundant in that case, but it will still be needed for Qt4 I guess?

I regret I do not know cmake more, could you help me please?
Comment 2 Christophe Giboudeaux 2018-06-19 10:51:20 UTC
The patch is fine for our package and won't break build with older Qt versions.
It would break the Qt4 build, however.
Comment 3 Christophe Giboudeaux 2018-06-19 10:52:54 UTC
Created attachment 774473 [details]
Patch to fix build

Here's a patch you can use for this package and submit upstream.
Comment 4 Petr Gajdos 2018-06-19 13:18:24 UTC
Thanks, package submitted to Tumbleweed. Corresponding pull request:
https://github.com/doxygen/doxygen/pull/772