Bugzilla – Bug 1091592
Firefox breaks KWin / Aurorae
Last modified: 2018-05-08 15:20:10 UTC
Created attachment 768761 [details] Screenshot of the broken Firefox window Firefox is interfering with KWin after an update in openSUSE Tumbleweed roughly a few hours ago. All other applications (including Thunderbird) work fine, but when I startup Firefox its window has no borders whereas the titlebar appears gray. The window can also not be resized, it can only be minimized / restored by dragging it from and to the screen edges. I'm attaching a screenshot of the broken FF window. The gray titlebar is NOT the theme I'm currently using (Aurorae), and I have no idea what skin the buttons to its upper-right are from either. KWin should not be allowing applications to have custom window managers, this might be an issue with some fundamental library.
Thanks for the report! I thought I got something wrong with my configurations. Same here. I am using openSUSE default theme (Breeze). The system is upgraded from snapshot 20180425 to snapshot 20180429.
Created attachment 768815 [details] Screenshot of the double titlebar Just great. Apparently this isn't a bug but some sort of new feature: It's called Client Side Decorations (CSD) and it basically means that Firefox now embeds and may use its own window manager, because why not break the OS with unnecessary functionality? First off I created a KWin window rule to force the normal titlebar to show up again. This causes two titlebars to appear, as visible in the screenshot I'm attaching here. I next had a chat on the Firefox IRC channel about this. Folks kept saying that it should be possible to disable with browser.tabs.drawInTitlebar in about:config, but that setting doesn't work for me and isn't intended until Firefox 60 from what I hear. The only thing that makes it go away is running FF with the following environment variable set: export MOZ_GTK_TITLEBAR_DECORATION=none I'm leaving this open in case the openSUSE crew can fix it in 59 so we don't have to wait until 60 for a solution. This clearly breaks the Firefox window for KDE users, and also looks ugly as it breaks the theme so many of us don't want it... additionally I understand the GTK client decoration shouldn't even be supported in version 59, so this shouldn't even be happening at all.
CSD was not applied for kwin before. Yes, we enabled that feature already in our builds but if it is applied to kwin and breaks things there it is broken upstream still. In any case if you want to help testing a little bit more it would help if you could try Firefox 60beta from the mozilla:beta repository and see if that is still an issue there.
(In reply to Wolfgang Rosenauer from comment #3) So it was a decision by the openSUSE devs to enable it? Good to know. I don't believe it was a good one personally, and would be happy if you could please consider reverting it: Firefox 60 will come with a way to enable / disabled this on demand I understand, which users can surely wait for. Indeed it looks pretty broken as is: Apart from the fact that the window doesn't have a title nor borders thus it can't be resized, it visually breaks the theme that all other widows have which looks very ugly. I might look for that repository later and consider testing this package: As long as it's a safe change and can be easily reverted without breaking anything, I do not mind checking it out and letting you know the results I get.
(In reply to Mircea Kitsune from comment #4) > So it was a decision by the openSUSE devs to enable it? Good to know. I > don't believe it was a good one personally, and would be happy if you could > please consider reverting it: Firefox 60 will come with a way to enable / > disabled this on demand I understand, which users can surely wait for. It was enabled for earlier versions already. The thing apparently broke just for 59 on kwin. We just enabled what was already in the codebase. The feature is supposed to detect if a windowmanager (and how far) can work with CSD. This won't change in FF 60 in principle. > Indeed it looks pretty broken as is: Apart from the fact that the window > doesn't have a title nor borders thus it can't be resized, it visually > breaks the theme that all other widows have which looks very ugly. You do not need to argue with us that it's broken. > I might look for that repository later and consider testing this package: As > long as it's a safe change and can be easily reverted without breaking > anything, I do not mind checking it out and letting you know the results I > get. The point is you will get FF60 anyway next week when it's released. If you get it with a bug on kwin or not depends on if you could help testing and we resolve the issue within the next 5/6 days.
(In reply to Wolfgang Rosenauer from comment #5) Thanks for clarifying. I thought this was a Firefox 59 specific issue at first. I just installed Firefox 59.99 / 60.0b16 from http://download.opensuse.org/repositories/mozilla:/beta/openSUSE_Tumbleweed I can confirm the issue goes away in this version and the functionality is exactly as expected: By default KWin continues acting as the window manager, and the new builtin decoration is only used if you go into about:config and set browser.tabs.drawInTitlebar to true. As long as that option remains set to false by default (especially for KDE users) there should be no more issues in the future.
I consider it fixed for FF60. Also just submitted a quick fix to TW.
created request id 603325
This is an autogenerated message for OBS integration: This bug (1091592) was mentioned in https://build.opensuse.org/request/show/603325 Factory / MozillaFirefox
This is an autogenerated message for OBS integration: This bug (1091592) was mentioned in https://build.opensuse.org/request/show/605381 15.0 / MozillaFirefox