Bug 1087486 - [storage-ng] Various storage NG related control.xml parameters not working
[storage-ng] Various storage NG related control.xml parameters not working
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: YaST2
Current
Other Other
: P1 - Urgent : Normal (vote)
: ---
Assigned To: YaST Team
Jiri Srain
https://trello.com/c/nujLPA7G
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-29 15:24 UTC by Richard Brown
Modified: 2019-04-15 12:18 UTC (History)
6 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Brown 2018-03-29 15:24:54 UTC
Observed on Kubic, Tumbleweed, and Leap 15, the following control.xml parameters seem to have the following flaws. I have checked that all of the below are mentioned in https://github.com/yast/yast-storage-ng/blob/master/doc/old_and_new_proposal.md and are expected to work in the new proposal

---

<proposal_settings_editable config:type="boolean">false</proposal_settings_editable>

EXPECTED BEHAVIOUR

Should prevent editing of the storage proposal

ACTUAL BEHAVIOUR

User can edit the storage proposal in both the Guided and Expert partitioner (see current Kubic snapshots - this value is set on all system roles there.

---

<snapshots_configurable config:type="boolean">false</snapshots_configurable>

EXPECTED BEHAVIOUR

Whether the user can change the previous setting in the UI. If false, they should not be able to change the snapshots setting

ACTUAL BEHAVIOUR

User can edit the storage proposal in both the Guided and Expert partitioner. For examples see see current Kubic snapshots - this value is set on all system roles there, or Leap 15 and tumbleweed, where the Transactional Server system role has it set

---

<expert_partitioner_warning config:type="boolean">true</expert_partitioner_warning>

EXPECTED BEHAVIOUR

If true, an extra warning pop-up is displayed if the user enters the expert partitioner during installation.

ACTUAL BEHAVIOUR

Pop-up is never displayed. For examples see see current Kubic snapshots - this value is set on all system roles there, or Leap 15 and tumbleweed, where the Transactional Server system role has it set
Comment 1 Steffen Winterfeldt 2018-04-03 13:04:27 UTC
I don't see neither proposal_settings_editable nor expert_partitioner_warning evaluated anywhere in the code.

See also the 'FIXME's here

https://github.com/yast/yast-storage-ng/blob/master/doc/old_and_new_proposal.md

which may or may not be true any longer.


Tracking in YaST scrum board.
Comment 2 José Iván López González 2018-04-17 14:23:17 UTC
These settings are now working again with yast2-storage-ng >= 4.0.156.

Note that in the case of "proposal_settings_editable" is set to "false", the button for "Guided Setup" might be still shown. If there are several candidate disks for installation, the first two steps of the Guided Setup (1. Select candidate disks, 2. Select root disk and what to remove) have to be accessible to decide where to install.

When the setting "expert_partitioner_warning" is set to "true", a warning is shown before entering the Expert Partitioner.

The setting "snapshots_configurable" continues working as before, that is, it allows (or not) to activate snapshots in the Guided Setup, but it does not interfere in the Expert Partitioner.

SR: https://build.suse.de/request/show/162127