Bug 1084076 - replace issue generator with agetty built in methods
replace issue generator with agetty built in methods
Status: RESOLVED WONTFIX
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: Thorsten Kukuk
E-mail List
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-03-06 09:01 UTC by Ludwig Nussel
Modified: 2018-03-06 14:46 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ludwig Nussel 2018-03-06 09:01:11 UTC
upstream agetty gained support reading issue.d to display issue snippets on the fly without intermediate, generated files:

https://github.com/karelzak/util-linux/commit/1fc82a1360305f696dc1be6105c9c56a9ea03f52

So far only /etc/issue.d, however something like /usr/lib/issue.d can be foreseen as it would immediately make sense in order for packages to provide snippets. That would be incompatible with what issue-generator puts in /usr/lib/issue.d. So I'd strongly advise to at least rename that directory to avoid potential conflicts with upstream in the future.

Alternatively and that's what I'd recommend is to drop issue generator in favor of agetty's built in capabilities. agetty already provides options to eg show any field from /etc/os-release and to list IP addresses. Should be fairly easy to extend that to ssh keys as well:

https://github.com/karelzak/util-linux/blob/master/term-utils/agetty.c#L2621
Comment 4 Thorsten Kukuk 2018-03-06 11:36:47 UTC
Ok, the agetty implementation is compatible with CoreOS or our issue-generator, there is no conflict, and RedHat will add a configure option to disable it.

No reason to worry.
Comment 5 Thorsten Kukuk 2018-03-06 12:26:20 UTC
agetty cannot replace issue-generator yet and there are no incompatibilities.
Comment 6 Ludwig Nussel 2018-03-06 14:46:18 UTC
meanwhile upstream will add support for /run and /usr