See also boo#1012138

k_mikhail@linux-mk500:~> thunar --version
Thunar 1.6.10 (Xfce 4.12)

Copyright (c) 2004-2015
	Команда разработчиков Thunar. Все права защищены.

Автор: Benedikt Meurer <benny@xfce.org>.

Об ошибках сообщайте на <http://bugzilla.xfce.org/>.

k_mikhail@linux-mk500:~> rpm -q thunar
thunar-1.6.10-4.6.x86_64

[3] k_mikhail@linux-mk500:~> coredumpctl | grep [tT]hunar
<skipped>
Птн 2017-02-17 19:51:48 EET   1607  1000   100  11 * /usr/bin/thunar

[4] k_mikhail@linux-mk500:~> coredumpctl gdb 1607
           PID: 1607 (Thunar)
           UID: 1000 (k_mikhail)
           GID: 100 (users)
        Signal: 11 (SEGV)
     Timestamp: Птн 2017-02-17 19:51:16 EET (7min ago)
  Command Line: Thunar --daemon
    Executable: /usr/bin/thunar
 Control Group: /user.slice/user-1000.slice/session-2.scope
          Unit: session-2.scope
         Slice: user-1000.slice
       Session: 2
     Owner UID: 1000 (k_mikhail)
       Boot ID: 1ce14bb138ad4e279a2e2d33226baf0c
    Machine ID: 4664bc7cba6aee90fe1efc7f571cbf28
      Hostname: linux-mk500
      Coredump: /var/lib/systemd/coredump/core.Thunar.1000.1ce14bb138ad4e279a2e2d33226baf0c.1607.1487353876000000.xz
       Message: Process 1607 (Thunar) of user 1000 dumped core.

GNU gdb (GDB; openSUSE Leap 42.2) 7.11.1
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-suse-linux".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://bugs.opensuse.org/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/bin/thunar...Reading symbols from /usr/lib/debug/usr/bin/thunar.debug...done.
done.

warning: core file may not match specified executable file.
[New LWP 1607]
[New LWP 28669]
[New LWP 2167]
[New LWP 2170]
[New LWP 28678]
[New LWP 2166]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `Thunar --daemon'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x7f36040b6ea0, 
    fundamental_type=fundamental_type@entry=80) at gtype.c:4033
4033	  node = lookup_type_node_I (type_instance->g_class->g_type);
[Current thread is 1 (Thread 0x7f3637955a00 (LWP 1607))]

[5] (gdb) bt
#0  0x00007f3634803a9d in g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x7f36040b6ea0, fundamental_type=fundamental_type@entry=80) at gtype.c:4033
#1  0x00007f36347e5fe7 in g_object_unref (_object=0x7f36040b6ea0) at gobject.c:3080
#2  0x0000000000437de2 in thunar_file_info_clear (file=file@entry=0x7f35f008f440) at thunar-file.c:894
#3  0x000000000043922c in thunar_file_load (file=file@entry=0x7f35f008f440, error=error@entry=0x0, cancellable=0x0)
    at thunar-file.c:1168
#4  0x000000000043ad53 in thunar_file_reload (file=0x7f35f008f440) at thunar-file.c:3926
#5  0x00007f363450d015 in g_main_context_dispatch (context=0x12fe5a0) at gmain.c:3154
#6  0x00007f363450d015 in g_main_context_dispatch (context=context@entry=0x12fe5a0) at gmain.c:3769
#7  0x00007f363450d388 in g_main_context_iterate (context=0x12fe5a0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3840
#8  0x00007f363450d64a in g_main_loop_run (loop=0x138daa0) at gmain.c:4034
#9  0x00007f36363d97b7 in IA__gtk_main () at gtkmain.c:1268
#10 0x00000000004223ad in main (argc=1, argv=0x7fffd0a3ef08) at main.c:312
(gdb)

Upstream report: https://bugzilla.xfce.org/show_bug.cgi?id=13359

Hello Mikhail,

I have created a patched version of Thunar which most likely fixes your reported bug.
You can download it from
https://software.opensuse.org/download.html?project=home%3Aronnypeine%3Abranches%3AopenSUSE%3ALeap%3A42.2%3AUpdate&package=thunar

Please test it. If you give me positive feedback, I will try to get this submitted.

The XFCE maintainers for opensuse seem to be dormant.

Kind regards,
Ronny

(In reply to Ronny Peine from comment #4)
> Hello Mikhail,
> 
> I have created a patched version of Thunar which most likely fixes your
> reported bug.
> You can download it from
> https://software.opensuse.org/download.
> html?project=home%3Aronnypeine%3Abranches%3AopenSUSE%3ALeap%3A42.
> 2%3AUpdate&package=thunar
> 
> Please test it. If you give me positive feedback, I will try to get this
> submitted.
> 
> The XFCE maintainers for opensuse seem to be dormant.

 
> Kind regards,
> Ronny

Hello, Ronny!

've re-installed thunar from your own repo. Thanks! Will try to reproduce - this can take some time, because this issue has floating nature. Will let you know.

(In reply to Mikhail Kasimov from comment #5)
> (In reply to Ronny Peine from comment #4)
> > Hello Mikhail,
> > 
> > I have created a patched version of Thunar which most likely fixes your
> > reported bug.
> > You can download it from
> > https://software.opensuse.org/download.
> > html?project=home%3Aronnypeine%3Abranches%3AopenSUSE%3ALeap%3A42.
> > 2%3AUpdate&package=thunar
> > 
> > Please test it. If you give me positive feedback, I will try to get this
> > submitted.
> > 
> > The XFCE maintainers for opensuse seem to be dormant.
> 
>  
> > Kind regards,
> > Ronny
> 
> Hello, Ronny!
> 
> 've re-installed thunar from your own repo. Thanks! Will try to reproduce -
> this can take some time, because this issue has floating nature. Will let
> you know.

've tried to copy huge pile of small (~ 100kb) files in amount of ~4000 files. And, seems, I'm lucky man. :)

[1] k_mikhail@linux-mk500:~> coredumpctl | grep 2017-02-24
Птн 2017-02-24 02:50:59 EET   1587  1000   100  11 * /usr/bin/thunar

[2] k_mikhail@linux-mk500:~> coredumpctl gdb 1587
           PID: 1587 (Thunar)
           UID: 1000 (k_mikhail)
           GID: 100 (users)
        Signal: 11 (SEGV)
     Timestamp: Птн 2017-02-24 02:50:22 EET (6min ago)
  Command Line: Thunar --daemon
    Executable: /usr/bin/thunar
 Control Group: /user.slice/user-1000.slice/session-2.scope
          Unit: session-2.scope
         Slice: user-1000.slice
       Session: 2
     Owner UID: 1000 (k_mikhail)
       Boot ID: d302005272cf47eb9669701d90d16de5
    Machine ID: 4664bc7cba6aee90fe1efc7f571cbf28
      Hostname: linux-mk500
      Coredump: /var/lib/systemd/coredump/core.Thunar.1000.d302005272cf47eb9669701d90d16de5.1587.1487897422000000.xz
       Message: Process 1587 (Thunar) of user 1000 dumped core.

GNU gdb (GDB; openSUSE Leap 42.2) 7.11.1
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-suse-linux".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://bugs.opensuse.org/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/bin/thunar...Reading symbols from /usr/lib/debug/usr/bin/thunar.debug...done.
done.

warning: core file may not match specified executable file.
[New LWP 1587]
[New LWP 1978]
[New LWP 1981]
[New LWP 24728]
[New LWP 24739]
[New LWP 1977]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `Thunar --daemon'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  g_type_check_instance_is_fundamentally_a (
    type_instance=type_instance@entry=0x300f690, 
    fundamental_type=fundamental_type@entry=80) at gtype.c:4033
4033	  node = lookup_type_node_I (type_instance->g_class->g_type);
[Current thread is 1 (Thread 0x7f05c9a5ba00 (LWP 1587))]


[3] (gdb) bt
#0  0x00007f05c6909a9d in g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x300f690, fundamental_type=fundamental_type@entry=80)
    at gtype.c:4033
#1  0x00007f05c68ebfe7 in g_object_unref (_object=0x300f690) at gobject.c:3080
#2  0x0000000000437de2 in thunar_file_info_init (iface=0x300f690)
    at thunar-file.c:393
#3  0x0000000003009500 in  ()
#4  0x000000000043922c in thunar_file_get_async_finish (object=0x17125a0, result=0x3009500, user_data=0x0) at thunar-file.c:1111
#5  0x00007f05c6613015 in g_main_context_dispatch (context=0x17125a0)
    at gmain.c:3154
#6  0x00007f05c6613015 in g_main_context_dispatch (context=context@entry=0x17125a0) at gmain.c:3769
#7  0x00007f05c6613388 in g_main_context_iterate (context=0x17125a0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3840
#8  0x00007f05c661364a in g_main_loop_run (loop=0x17a1aa0) at gmain.c:4034
#9  0x00007f05c84df7b7 in IA__gtk_main () at gtkmain.c:1268
#10 0x00000000004223ad in main (argc=1, argv=0x7ffc63ac2298) at main.c:278

Hello Mikhail,

to give you further assistance in the upstream report, my patched version of Thunar incorporates most of the changes of Thunar 1.6.11 except translations updates and the fixes for the bugs #11357 and #8695.

I attach my patch thunar-bugfixes.patch which is used on Thunar 1.6.10.

Kind regards,
Ronny

Created attachment 715353 [details]
Patch used of patched version from ronnypeine

(In reply to Ronny Peine from comment #8)
> Created attachment 715353 [details]
> Patch used of patched version from ronnypeine

Hello!

========================================
k_mikhail@linux-mk500:~> rpm -q thunar
thunar-1.6.10-28.1.x86_64
========================================

Does this thunar version (from ronnypeine repo, certainly) contain your attached patch?

Hi Mikhail,

yes this patch is the only difference between my package and the Leap 42.2 version. I created this patch to incorporate the bugfixes.
See https://build.opensuse.org/package/show/home:ronnypeine:branches:openSUSE:Leap:42.2:Update/thunar

for all information.

Kind regards,
Ronny

(In reply to Ronny Peine from comment #10)
> Hi Mikhail,
> 
> yes this patch is the only difference between my package and the Leap 42.2
> version. I created this patch to incorporate the bugfixes.
> See
> https://build.opensuse.org/package/show/home:ronnypeine:branches:openSUSE:
> Leap:42.2:Update/thunar
> 
> for all information.
> 
> Kind regards,
> Ronny

Hello!

Ok, thnx! still trying to catch segv-s again with version from your repo...

Hello Mikhail,

if I have interpreted your comment #6 correctly than you have already reproduced a coredump with my patched version, so I don't think it makes much sense to do this further. I had only hoped for my version to be a fix for your bug, too, because of the changelog I have found for Thunar 1.6.11 (Fix a crash for on cut/pasting of multiple files (bxo #12260)) which I used as a base for my patch.

You could try to contact Simon Steinbeiss of the XFCE team, he fixed the crash on rename bug quite well. This is most likely a race condition, too.

Kind regards,
Ronny

(In reply to Ronny Peine from comment #12)
> Hello Mikhail,
> 
> if I have interpreted your comment #6 correctly than you have already
> reproduced a coredump with my patched version,

In general way - yes, but today (already yesterday for my time-zone :) ) thunar was updated up-to thunar-1.6.10-28.1.x86_64 version, but I've reproduced to crash before this version, but also from your home: repo.

> so I don't think it makes much sense to do this further.

Anyway, will try to reproduce -- I'm lucky. ;)

> I had only hoped for my version to be a fix for your bug, too, because of the changelog I have found for Thunar 1.6.11
> (Fix a crash for on cut/pasting of multiple files (bxo #12260)) which I used
> as a base for my patch.
> 
> You could try to contact Simon Steinbeiss of the XFCE team, he fixed the
> crash on rename bug quite well. This is most likely a race condition, too.

That's an idea, thanks! Will try to.

(In reply to Ronny Peine from comment #12)
> Hello Mikhail,
> 
> if I have interpreted your comment #6 correctly than you have already
> reproduced a coredump with my patched version, so I don't think it makes
> much sense to do this further. I had only hoped for my version to be a fix
> for your bug, too, because of the changelog I have found for Thunar 1.6.11
> (Fix a crash for on cut/pasting of multiple files (bxo #12260)) which I used
> as a base for my patch.
> 
> You could try to contact Simon Steinbeiss of the XFCE team, he fixed the
> crash on rename bug quite well. This is most likely a race condition, too.
> 
> Kind regards,
> Ronny

Hello Ronny!

Here is Simon's reply I've got:
===============================================================================
Hi,

well it's hard to know what you're really testing here if it's 1.6.10 with "some patches". This was one of the reasons for me to push the release of 1.6.11: to give testers a clear new baseline and to avoid the bug reporting mess that we've been in. There were multiple bugreports about similar problems, sometimes duplicates, sometimes single bugreports discussing multiple issues... Not very helpful in the end.

So my advice is: try to build 1.6.11 from git if you can (it really isn't that hard, at least in Debian-land, apt-get build-dep is really helpful, maybe SUSE's zypper has something similar) or if you can't get someone to package that for you. Then rinse and repeat (your test, I mean).

Also, you can try this testcase from Xubuntu:
http://packages.qa.ubuntu.com/qatracker/milestones/361/builds/117794/testcases/1681/results

Cheers
Simon
===============================================================================

Now I'm running test-case from Xubuntu, but I think I won't get thunar's crash here, because during this time I hadn't success on crashing thunar manually.

So, if (open-)SUSE XFCE maintainers are alive (have a very strong hope they are), will be nice if they wake up here. :)

Hello Mikhail,

thanks for your work. I can create a Thunar 1.6.11 package for openSUSE 42.2 if feedback is positive in boo #1011518.
You could than test with this version and report back to Simon.

Kind regards,
Ronny

(In reply to Ronny Peine from comment #15)
> Hello Mikhail,
> 
> thanks for your work. I can create a Thunar 1.6.11 package for openSUSE 42.2
> if feedback is positive in boo #1011518.
> You could than test with this version and report back to Simon.
> 
> Kind regards,
> Ronny

Hello!

Seems the nature of these two reports is the same. I had also problems (periodical, with floating reproducing) on renaming files too. But when I decided to file a bug abou this, I got segv on Ctrl-C Ctrl-V operation. So, I named my report according to my last caught.

(In reply to Mikhail Kasimov from comment #16)
> (In reply to Ronny Peine from comment #15)
> > Hello Mikhail,
> > 
> > thanks for your work. I can create a Thunar 1.6.11 package for openSUSE 42.2
> > if feedback is positive in boo #1011518.
> > You could than test with this version and report back to Simon.
> > 
> > Kind regards,
> > Ronny
> 
> Hello!
> 
> Seems the nature of these two reports is the same. I had also problems
> (periodical, with floating reproducing) on renaming files too. But when I
> decided to file a bug abou this, I got segv on Ctrl-C Ctrl-V operation. So,
> I named my report according to my last caught.

Hello Mikhail,

can you please try to reproduce your bug with my branched thunar version 1.6.10-28.1 and report back if the bug still remains? I'm a bit unsure if your previous test is maybe flawed or something.

Kind regards,
Ronny

(In reply to Ronny Peine from comment #17)
> Hello Mikhail,
> 
> can you please try to reproduce your bug with my branched thunar version
> 1.6.10-28.1 and report back if the bug still remains? I'm a bit unsure if
> your previous test is maybe flawed or something.

Already 've tries all that days I've 1.6.10-28.1 from your own repo + using Xubuntu's test-case in background. No crashes... even already boring a little bit. :)

Hello Stefan,

as it seems, this bug is also fixed by my patch, which you have already taken for X11:xfce. I think it is most likely related to the following fix in Thunar 1.6.11 upstream which I have integrated in my patch, too (see https://git.xfce.org/xfce/thunar/tag/?id=thunar-1.6.11):
- Fix a crash for on cut/pasting of multiple files (Bug #12260)

So it would be really nice to get this into Leap:)
I hope assigning it to you is ok. You can close this as resolved closed when the update is available.

@Mikhail:
Please report Simon and in your upstream report, that this is fixed in Thunar 1.6.11 and our patched version, so they can close the bug.

Thanks four your work.
Kind regards,
Ronny

(In reply to Ronny Peine from comment #19)
the update is available.

> @Mikhail:
> Please report Simon and in your upstream report, that this is fixed in
> Thunar 1.6.11 and our patched version, so they can close the bug.

My email to Simon on 27 Feb 2017, 22:42
===================================
Hello!


Seems, I can't catch segv on Xubuntu's test-case. So, let us be sure, that patched 1.6.10 and 1.6.11 Thunar versions are ok.

Thank you again for your assistance!
===================================

And just 've marked my upsteam report on bxo as fixed.

Note that I will import thunar-1.6.11 into X11:xfce and tumbleweed after we are through with this maintenance update, but getting the version update into 42.1/42.2 will be harder and need more patching, so I'd go for Ronny's patch for now.

maintenance requests 460924 and 460925 for 42.1 and 42.2 created

https://build.opensuse.org/request/show/460924
https://build.opensuse.org/request/show/460925

(In reply to Stefan Seyfried from comment #21)
> Note that I will import thunar-1.6.11 into X11:xfce and tumbleweed after we
> are through with this maintenance update, but getting the version update
> into 42.1/42.2 will be harder and need more patching, so I'd go for Ronny's
> patch for now.

No problem, thanks! It's already very nice, that deal moved from its dead point a little bit.

openSUSE-RU-2017:0652-1: An update that has two recommended fixes can now be installed.

Category: recommended (important)
Bug References: 1011518,1012237
CVE References: 
Sources used:
openSUSE Leap 42.2 (src):    thunar-1.6.10-6.1
openSUSE Leap 42.1 (src):    thunar-1.6.10-7.1

Would you like to check once more if any crashes were eventually transformed into program deadlocks?

Do you find that information from reports like the following can be also relevant here?
* Occasional freeze of thunar when file names are changed
  https://bugzilla.xfce.org/show_bug.cgi?id=13472#c1

* Crash when renaming single file in folder
  https://bugzilla.xfce.org/show_bug.cgi?id=12264#c184

Probably related: https://bugzilla.opensuse.org/show_bug.cgi?id=977061

(In reply to Sebastian Wagner from comment #26)
> Probably related: https://bugzilla.opensuse.org/show_bug.cgi?id=977061

Yes, reports boo#977061 , boo#1011518 , boo#1012237 have the same nature.

forgot to set this to fixed after online update was shipped